Skip to content
This repository has been archived by the owner on Jan 20, 2023. It is now read-only.

Add sample plugin for Task API #33

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Add sample plugin for Task API #33

merged 1 commit into from
Mar 14, 2019

Conversation

RomanNikitenko
Copy link
Contributor

@RomanNikitenko RomanNikitenko commented Mar 12, 2019

The plugin demonstrates using of the Task API.

The short demo: https://youtu.be/Wfi5brEDojI

Signed-off-by: Roman Nikitenko rnikiten@redhat.com

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@benoitf
Copy link
Member

benoitf commented Mar 14, 2019

hello, what will be the difference between this example and eclipse-che/che-theia#97
because it seems that if it's almost the same goal then we don't need an example as we've a real-world example on che-theia

@RomanNikitenko
Copy link
Contributor Author

RomanNikitenko commented Mar 14, 2019

We use plugin API in ours plugins, so sure these ones are examples how to use API.
In my opinion the difference is:

  • user may not even know about which plugin he can use as sample for using corresponding API - but
    it's expected to search good example in che-theia-samples
  • our plugins can contain a lot of logic vs for che-theia-samples case it's easier to find code you are interested in.

For current case I removed all che specific things, simplified as far as possible che-task plugin and represent it as sample.
But I don't mind - we can use che-task-plugin as sample, up to you.

@RomanNikitenko RomanNikitenko merged commit 13ae224 into master Mar 14, 2019
@RomanNikitenko RomanNikitenko deleted the taskPlugin branch March 14, 2019 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants